-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEEEP] [PM-2844] Add custom error codes for server API exceptions #3141
Draft
r-tome
wants to merge
24
commits into
main
Choose a base branch
from
PM-2844-beeep-add-custom-error-codes-for-server-api-exceptions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[BEEEP] [PM-2844] Add custom error codes for server API exceptions #3141
r-tome
wants to merge
24
commits into
main
from
PM-2844-beeep-add-custom-error-codes-for-server-api-exceptions
+384
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage from resource files if the error thrown is an error code
…odes for exceptions
Fixed Issues
|
…ver-api-exceptions # Conflicts: # src/Api/Utilities/ExceptionHandlerFilterAttribute.cs # src/Api/Vault/Controllers/SyncController.cs # src/Core/Services/Implementations/PolicyService.cs
…ver-api-exceptions
… and configure the accept language header
…ver-api-exceptions
…zerFactory for string localization
…er for improved error message handling
…ionHandlerFilterAttribute to use a dedicated extension method for improved clarity and maintainability
… improved clarity and maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
This PR introduces centralized error management by creating a class with constant strings for expected exception error codes. It replaces hardcoded error messages with these error code constants, improving maintainability and consistency. Additionally, a resource file maps the error codes to their corresponding messages for easier localization and customization.
Code changes
Before you submit
dotnet format --verify-no-changes
) (required)