-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-13650] Use transpiled JS build #9
Conversation
New Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
=======================================
Coverage 62.86% 62.86%
=======================================
Files 179 179
Lines 12685 12685
=======================================
Hits 7974 7974
Misses 4711 4711 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I abandoned this approach since it turned out we need to do this differently depending on what client we build for. This logic now lives in the clients repository.
https://github.com/bitwarden/clients/blob/main/apps/web/src/app/platform/web-sdk-client-factory.ts
Hmm, when I tested it last week it was using the |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13650
📔 Objective
We're bundling the transpiled WASM to JS SDK, but never actually using it. This PR loads the transpiled JS when WASM isn't supported.
I've also added typing support for the init function.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes