Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10941] Add ssh import #82

Merged
merged 28 commits into from
Dec 19, 2024

Merge branch 'km/pm-10941/ssh-import' of github.com:bitwarden/sdk-intโ€ฆ

8d70e02
Select commit
Loading
Failed to load commit list.
Merged

[PM-10941] Add ssh import #82

Merge branch 'km/pm-10941/ssh-import' of github.com:bitwarden/sdk-intโ€ฆ
8d70e02
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 19, 2024 in 0s

64.75% (+0.33%) compared to 2c22c4f

View this Pull Request on Codecov

64.75% (+0.33%) compared to 2c22c4f

Details

Codecov Report

Attention: Patch coverage is 89.44954% with 23 lines in your changes missing coverage. Please review.

Project coverage is 64.75%. Comparing base (2c22c4f) to head (8d70e02).

Files with missing lines Patch % Lines
crates/bitwarden-wasm-internal/src/ssh.rs 0.00% 10 Missing โš ๏ธ
crates/bitwarden-ssh/src/generator.rs 86.53% 7 Missing โš ๏ธ
crates/bitwarden-ssh/src/import.rs 97.91% 3 Missing โš ๏ธ
crates/bitwarden-ssh/src/error.rs 0.00% 2 Missing โš ๏ธ
crates/bitwarden-ssh/src/lib.rs 90.00% 1 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   64.41%   64.75%   +0.33%     
==========================================
  Files         188      190       +2     
  Lines       13819    13979     +160     
==========================================
+ Hits         8902     9052     +150     
- Misses       4917     4927      +10     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.