Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16078] Add cargo sort #80

Merged
merged 3 commits into from
Dec 16, 2024
Merged

[PM-16078] Add cargo sort #80

merged 3 commits into from
Dec 16, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Dec 16, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16078

📔 Objective

Validate the cargo.toml is sorted correctly.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from dani-garcia December 16, 2024 11:21
@Hinton Hinton changed the title Add cargo sort [PM-16078] Add cargo sort Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

Logo
Checkmarx One – Scan Summary & Details01450ded-78cd-4664-84a8-32612cd27f91

No New Or Fixed Issues Found

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.43%. Comparing base (5fc933f) to head (823f9f0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   64.43%   64.43%           
=======================================
  Files         188      188           
  Lines       13832    13832           
=======================================
  Hits         8912     8912           
  Misses       4920     4920           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the current release won't work correctly, and we'd have to use git main instead: DevinR528/cargo-sort#67

@Hinton Hinton requested a review from dani-garcia December 16, 2024 11:40
@Hinton Hinton merged commit c3053cd into main Dec 16, 2024
39 checks passed
@Hinton Hinton deleted the cargo-sort branch December 16, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants