-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-work publish workflow to automatically set version if not defined #17
Conversation
f4ab3b9
to
b73d2b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
=======================================
Coverage 62.85% 62.85%
=======================================
Files 179 179
Lines 12688 12688
=======================================
Hits 7975 7975
Misses 4713 4713 ☔ View full report in Codecov by Sentry. |
@bitwarden/dept-bre is there a way to ensure we only publish wasm IF the "run tests" workflow succeeds? I.e. depend on the result of another workflow. |
script: | | ||
await github.rest.actions.createWorkflowDispatch({ | ||
owner: 'bitwarden', | ||
repo: 'sdk-internal', | ||
workflow_id: 'publish-wasm-internal.yml', | ||
ref: 'main', | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: is this how GH actions work? You have to trigger another workflow using a script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can do it this way, but you can also use a workflow_call trigger in the workflow you want to call. There are pros and cons to each method.
The easiest way would be to call the "run tests" workflow in another job and add it to the |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13058
📔 Objective
Publish wasm automatically on merge to main. Determine version from job-id and branch.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes