Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore invalid passkey credentials #16

Closed
wants to merge 1 commit into from

Conversation

dani-garcia
Copy link
Member

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

Change credentials_for_autofill to return only the decryptable passkeys in case any of them aren't decryptable instead of just erroring outright. The error and cipher id are logged for ease of debugging.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 62.84%. Comparing base (5905354) to head (64f45d5).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-fido/src/authenticator.rs 0.00% 11 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   62.85%   62.84%   -0.01%     
==========================================
  Files         179      179              
  Lines       12688    12689       +1     
==========================================
  Hits         7975     7975              
- Misses       4713     4714       +1     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@dani-garcia dani-garcia closed this Nov 7, 2024
@dani-garcia dani-garcia deleted the ps/ignore-invalid-credentials branch November 7, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant