Skip to content

Commit

Permalink
Fix memory_dumping Dockerfile (#14)
Browse files Browse the repository at this point in the history
## ๐ŸŽŸ๏ธ Tracking

<!-- Paste the link to the Jira or GitHub issue or otherwise describe /
point to where this change is coming from. -->

## ๐Ÿ“” Objective

When we moved `bitwarden-sm` to `bitwarden_license`, the memory dump
docker tool broke as it was not copying those files over.

Because this is just a local test tool, rather than just copy everything
over which would cause frequent cache busting, we can remove the
`bitwarden_license` folder from the workspace.

## โฐ Reminders before review

- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or
informed the documentation
  team

## ๐Ÿฆฎ Reviewer guidelines

<!-- Suggested interactions but feel free to use (or not) as you desire!
-->

- ๐Ÿ‘ (`:+1:`) or similar for great changes
- ๐Ÿ“ (`:memo:`) or โ„น๏ธ (`:information_source:`) for notes or general info
- โ“ (`:question:`) for questions
- ๐Ÿค” (`:thinking:`) or ๐Ÿ’ญ (`:thought_balloon:`) for more open inquiry
that's not quite a confirmed
  issue and could potentially benefit from discussion
- ๐ŸŽจ (`:art:`) for suggestions / improvements
- โŒ (`:x:`) or โš ๏ธ (`:warning:`) for more significant problems or
concerns needing attention
- ๐ŸŒฑ (`:seedling:`) or โ™ป๏ธ (`:recycle:`) for future improvements or
indications of technical debt
- โ› (`:pick:`) for minor or nitpick changes
  • Loading branch information
dani-garcia authored Oct 29, 2024
1 parent 9c30b63 commit 3860206
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions crates/memory-testing/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ COPY Cargo.toml Cargo.lock /app/
COPY crates/bitwarden-crypto/Cargo.toml /app/crates/bitwarden-crypto/
COPY crates/memory-testing/Cargo.toml /app/crates/memory-testing/

# Patch Cargo.toml to remove `, "bitwarden_license/*"` from the members array
RUN sed -i 's/, "bitwarden_license\/\*"\(,\?\)/\1/' Cargo.toml

RUN mkdir -p /app/crates/bitwarden-crypto/src \
/app/crates/bitwarden-crypto/benches \
/app/crates/memory-testing/src \
Expand Down

0 comments on commit 3860206

Please sign in to comment.