-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade dependencies, move to type script #38
base: master
Are you sure you want to change the base?
upgrade dependencies, move to type script #38
Conversation
Regarding this comment:
This PR is not trying to do any functional updates. |
Perhaps we should also move from travis to github actions. |
Updates:
|
|
@motorina0 @junderw any updates on this PR? ran into a build issue today related to an older version of secp256k1 |
Am mentioned here, it is not clear if this library should be maintained or just archived. Also |
I'm willing to merge this.
Maybe we should also mention BIP322. I've been thinking about how to implement BIP322, but since it requires a script interpreter, I think maybe we should make it generic with a function parameter that solves the script and returns true or false... then we can offer defaults for p2pkh, p2wpkh, p2sh-p2wpkh, and encourage others to submit solvers for other script types. (but anyone can pass in their own solver function)... That said, BIP322 adoption is near-zero right now, so I'm putting it off. |
Oh no! I totally missed this one 🤦♂️ |
@junderw @motorina0 any update on this ? I couldnt |
This PR has no functional changes.
The main goals are to:
secp256k1
and move to injectabletiny-secp256k1