Add NODE_TXRELAY_V2. #30837
Add NODE_TXRELAY_V2. #30837
Conversation
This does not add default signaling of NODE_TXRELAY_V2 as node local services.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. |
| @@ -329,6 +329,9 @@ enum ServiceFlags : uint64_t { | |||
| // NODE_P2P_V2 means the node supports BIP324 transport | |||
| NODE_P2P_V2 = (1 << 11), | |||
|
|
|||
| // NODE_TXRELAY_V2 means the node supports BIPXXX transaction-relay v2 protocol | |||
| NODE_TXRELAY_V2 = (1 << 12), | |||
There was a problem hiding this comment.
(in case you're not waiting for concept acks)
/src/protocol.cpp:94:13: error: enumeration value 'NODE_TXRELAY_V2' not handled in switch [-Werror,-Wswitch]
94 | switch ((ServiceFlags)service_flag) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
There was a problem hiding this comment.
will fix it, still looking more for reviews on the BIPs themselves for the disruption minimization approach of restraining the acceptance of unsolicited transactions among upgraded peers only.
|
🚧 At least one of the CI tasks failed. HintsMake sure to run all tests locally, according to the documentation. The failure may happen due to a number of reasons, for example:
Leave a comment here, if you need help tracking down a confusing failure. |
This is the top commit from #30572, where the new node service bit support commit is extracted on its own.
See the corresponding BIP draft for motivation: bitcoin/bips#1663
Dissociating this change from halting the processing of unrequested transaction, allow the node service bit support to be used for further policies and mechanisms, beyond this mechanism only.