BIP47: replace "identifically" with "identically" #1723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
reviewed
Dec 18, 2024
| @@ -338,7 +338,7 @@ In order to use Bitmessage notification, the recipient must have a Bitmessage cl | |||
|
|
|||
| ==Version 2== | |||
|
|
|||
| Version 2 payment codes behave identifically to version 1 payment codes, except as modified below. | |||
| Version 2 payment codes behave identically to version 1 payment codes, except as modified below. | |||
There was a problem hiding this comment.
I think "identific" is an older and relatively rare word that means "identical in action" and so isn't necessarily in need of being changed.
jonatack
changed the title
|
Thank you for your proposal, but the word doesn't seem wrong and the BIP is in Final status, so I think we can leave the text as it is. |
|
@jonatack I have reviewed your comments, thank you, and I agree with you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.