Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos and grammar in multiple BIPs #1719

Closed
wants to merge 3 commits into from
Closed

Fix typos and grammar in multiple BIPs #1719

wants to merge 3 commits into from

Conversation

HubertIGL
Copy link

This PR fixes several typographical and grammatical errors across multiple BIP documents.

Changes in bip-0372.mediawiki:

  • "involve" → "evolve"
    • Corrects word choice as "evolve" better describes the progressive development of standards
  • "addresses" → "addressed"
    • Fixes verb tense to match the passive voice construction
  • "Appenxix" → "Appendix"
    • Fixes misspelling of "Appendix"

Changes in bip-0381.mediawiki:

  • "acceps" → "accepts"
    • Fixes misspelling of "accepts"

Changes in bip-0384.mediawiki:

  • "implementation" → "implementations"
    • Changes to plural form as it refers to multiple possible implementations
  • "are" → "is"
    • Fixes subject-verb agreement with singular "software"

achow101
achow101 reviewed Dec 17, 2024
View reviewed changes
bip-0384.mediawiki
As this is a wholly new descriptor, it is not compatible with any implementation.
However the scripts produced are standard scripts so existing software are likely to be familiar with them.
As this is a wholly new descriptor, it is not compatible with any implementations.
However the scripts produced are standard scripts so existing software is likely to be familiar with them.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are is correct, software is plural

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1720

@achow101
done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to close a PR and open a new one to make a change to it.

@HubertIGL HubertIGL closed this by deleting the head repository Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achow101 achow101 achow101 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HubertIGL @achow101