Add bip-txrelayv2 #1663
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,54 @@ | ||||||
| <pre> | ||||||
| BIP: XXX | ||||||
| Layer: Peer Services | ||||||
| Title: Transaction Relay V2 | ||||||
| Author: Antoine Riard <[email protected]> | ||||||
| Comments-Summary: No comments yet. | ||||||
| Comments-URI: https://github.com/bitcoin/bips/wiki/Comments:BIP-0XXX | ||||||
| Status: Draft | ||||||
| Type: Standards Track | ||||||
| Created: 2024-09-05 | ||||||
| License: GPLv2 | ||||||
| </pre> | ||||||
|
|
||||||
| ==Abstract== | ||||||
|
|
||||||
| This BIP proposes a new Bitcoin transaction relay protocol by introducing new | ||||||
| signaling support, which can be further used by nodes to negotiate new transaction | ||||||
| relay mechanisms and policies. | ||||||
|
|
||||||
| ==Motivation== | ||||||
|
|
||||||
| Historically, upgrades to the transaction relay protocols have been down by updating | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| the protocol version number, and upgraded peers expecting support for new p2p messages | ||||||
| processing or alteration in current processing of p2p messages from equivalently upgraded | ||||||
| peers. | ||||||
|
|
||||||
| This upgrade mechanism raise issues if new processing of current p2p messages is sanctionned | ||||||
|
There was a problem hiding this comment. Nice to see the new typos CI working (edit: though it doesn't seem to catch everything, hm)
Suggested change
(you can run it locally by installing https://github.com/crate-ci/typos and then running |
||||||
| by an upgraded peer at the peering level by a disconnection of the violating non-upgraded peers. | ||||||
| Non-upgraded peers and clients can see their transaction broadcast silently failing for a subset | ||||||
| of theirs opened connections. | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| We can improve current upgrade mechanism of the transaction relay protocol by introducing a new | ||||||
|
There was a problem hiding this comment.
Suggested change
missing "the", and "introducing" implies new |
||||||
| node service bit to signal support for a new v2 transaction relay protocol. Within this protocol, | ||||||
| nodes can negotiate new transaction relay mechanisms and policies. | ||||||
|
|
||||||
| ==Specification== | ||||||
|
|
||||||
| Peers supporting the v2 transaction relay protocol SHOULD support the Version 2 P2P Encrypted | ||||||
| Transport Protocol as specified by BIP324. | ||||||
|
|
||||||
| Peers supporting the v2 transaction relay protocol signal support by adverstising | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| the 13th bit service flag in the addr p2p messages (`ADDR` and `ADDRV2`). | ||||||
|
|
||||||
| ==Backward compatibility== | ||||||
|
|
||||||
| Older clients remain fully compatible and interoperable after this change. | ||||||
|
Comment on lines
+44
to
+46
There was a problem hiding this comment. Please be sure to include sufficient detail in the spec or compatibility section to explain why this is the case. There was a problem hiding this comment. This is the case - Earliest version behavior can be applied on the linked implementation code is bitcoin core 29.0. |
||||||
|
|
||||||
| ==Implementation== | ||||||
|
|
||||||
| https://github.com/bitcoin/bitcoin/pull/30572 | ||||||
|
|
||||||
| ==Copyright== | ||||||
|
|
||||||
| This BIP is licensed under the GPLv2. | ||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you perhaps reconsider the title? This sounds somewhat similar to the v2 P2P protocol that was recently deployed. Maybe something along the lines of "Behavior regarding unsolicited Transactions", if I’m getting the gist of what you are thinking about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentional to be similar to BIP24 and the upgrade of the V2 P2P protocol. Before the BIP design and implementation, the peer-to-peer protocol was not versioned, neither really encrypted. Similarly, we’re introducing a versioning of the transaction-relay protocol, which a node can use to selectively support policies and mechanisms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this naming can be easily confused with v2 p2p and v3 transaction relay; differentiated naming would be beneficial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll let you come with a better name, v2 p2p is the 2nd version of the p2p protocol, of which technically this transaction relay v2 protocol should lay on top. v3 transaction relay if you mean the TRUC thing it’s about the transaction versioning (the
nVersiontransaction field).