-
-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inform the client if it subscribes to a new topic #979
base: main
Are you sure you want to change the base?
Conversation
remove other complex logic
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #979 +/- ##
==========================================
+ Coverage 65.82% 65.85% +0.02%
==========================================
Files 53 53
Lines 7737 7746 +9
==========================================
+ Hits 5093 5101 +8
- Misses 1799 1801 +2
+ Partials 845 844 -1 ☔ View full report in Codecov by Sentry. |
@binwiederhier Thanks for looking into this, once you find some time :) Would really appreciate! |
Deployment
I think the Android app needs to be released first, before the server is deployed, so the client can deal with the case of re-registration on 404.
Paired with binwiederhier/ntfy-android#70
Closes #664