Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Wrong character width in Terminal #1694

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

guruathwal
Copy link
Contributor

@guruathwal guruathwal commented Mar 8, 2021

  • Fix: Wrong character width in the Terminal when the first character received has a larger width (originated from Supports Scroll gcode messages in terminal #1171). The character info was being fetched only for the first character on a page, this resulted in all the character on the page being rendered with spacing based on the first character's width.

@digant73
Copy link
Contributor

digant73 commented Mar 8, 2021

not related to the bug, but I would also consider a further improvement consisting of using different colors for the requests and responses in the terminal. E.g. I would configure a second color just slighly less/more opcaque/brighter than the other one. That should make the readability even better than now. It could be tested first with an hard coded color

@guruathwal
Copy link
Contributor Author

Did you plant any spyware on my PC? I am actually working on this.
image

@oldman4U
Copy link
Contributor

oldman4U commented Mar 8, 2021

We get a live coverage of your screen here in Europe. Free TV.

You didn’t know this!!??

@guruathwal
Copy link
Contributor Author

Ohh crap. I need to realign my satellite again.

@digant73
Copy link
Contributor

digant73 commented Mar 8, 2021

Did you plant any spyware on my PC? I am actually working on this.
image

I suspect the same in my home :-).
What about to test also orange and MAT orange (if it is present). the contrast should be less drastic and nice to see. In general I was thinking to use the MAT version for one of the two colors. Although I suppose both colors will be made configurable in config.ini

@guruathwal
Copy link
Contributor Author

There are two alternative to setting color through config.ini

  1. option to select from preset color combo. (1byte RAM)
  2. option to select any color for both.(4bytes RAM)

@bigtreetech bigtreetech merged commit cfccffd into bigtreetech:master Mar 9, 2021
jeffeb3 pushed a commit to V1EngineeringInc/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants