Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: boot issue in marlin mode and prevent mode switching while printing, wrong keywords in Popup dialog #1680

Merged
merged 18 commits into from
Mar 7, 2021
Merged

Bugfix: boot issue in marlin mode and prevent mode switching while printing, wrong keywords in Popup dialog #1680

merged 18 commits into from
Mar 7, 2021

Conversation

guruathwal
Copy link
Contributor

@guruathwal guruathwal commented Mar 7, 2021 •
edited
Loading

Resolves: #1657, Resolves: #1676

@guruathwal
rewrite terminal menu
724ff59 
- clean-up and re-write Terminal menu to remove unnecessary RAM usage.
@guruathwal
remove global variables from custom G-code menu
0a60afb
@guruathwal
show only compatible parameters in machine settings
ecd5e1c 
- Reduce RAM usage.
- Only parameters reported by machine are visible.
@guruathwal
Update SendGcode.c
093a153
@guruathwal
Update Move.c
3852126
@guruathwal
Update Print.c
7375828
@guruathwal
misc fix
a1f80fe
@guruathwal
Update Configuration.h
9e7d3eb
@guruathwal
Update SendGcode.c
35ea772
@guruathwal
Update SendGcode.c
13d8355
@guruathwal
add material theme option for keyboard and numpad, Fix long title dis…
defce44 
…play in numpad
@guruathwal
Fix wrong Ext minimum and maximum values in numpad
05576cc
@guruathwal
Merge remote-tracking branch 'upstream/master' into dev
75fe320
@guruathwal
Update SendGcode.c
0602769
@guruathwal
Fix marlin boot issue
a48c451
@guruathwal
prevent switching to printing screen if marlin mode is active
ea4022d
@guruathwal
Merge remote-tracking branch 'upstream/master' into dev
a42286e
@oldman4U oldman4U mentioned this pull request Mar 7, 2021
Closed
@guruathwal guruathwal changed the title Fix boot issue in marlin mode and prevent mode switching while printing Bugfix: boot issue in marlin mode and prevent mode switching while printing, wrong keywords in Popup dialog Mar 7, 2021
@bigtreetech bigtreetech merged commit 33a0125 into bigtreetech:master Mar 7, 2021
kisslorand added a commit to kisslorand/BIGTREETECH-TFT that referenced this pull request Mar 7, 2021
@kisslorand
Bugfix for PR bigtreetech#1680
8ba5e37
@kisslorand kisslorand mentioned this pull request Mar 7, 2021
Merged
bigtreetech pushed a commit that referenced this pull request Mar 7, 2021
@kisslorand
Bugfix for PR #1680 (#1681)
2debb49
@radek8
Copy link
Contributor

radek8 commented Mar 7, 2021 •
edited
Loading

Problem #1676 is fixed.
The description of the buttons is already displayed correctly, but after clicking the button, the display freezes.

guruathwal added a commit to guruathwal/BIGTREETECH-TouchScreenFirmware that referenced this pull request Mar 7, 2021
@guruathwal
Revert "Bugfix for PR bigtreetech#1680 (bigtreetech#1681)"
1154d19 
This reverts commit 2debb49.
@guruathwal guruathwal mentioned this pull request Mar 7, 2021
Merged
@guruathwal
Copy link
Contributor Author

@Msq001 There seems to be a problem with Printing.sys file after PR #1562 (I checked on TFT43, TFT35v2 and TFT70). @radek8 can you check with #1655 to confirm?

@radek8
Copy link
Contributor

radek8 commented Mar 7, 2021

When using # 1655 there is a bad description on the confirmation buttons.
When the button is pressed, the display responds correctly

@DaStivi DaStivi mentioned this pull request Mar 8, 2021
Closed
@radek8 radek8 mentioned this pull request Mar 11, 2021
Closed
jeffeb3 pushed a commit to V1EngineeringInc/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 10, 2021
@guruathwal
Bugfix: boot issue in marlin mode and prevent mode switching while pr…
86075de 
…inting, wrong keywords in Popup dialog (bigtreetech#1680)
jeffeb3 pushed a commit to V1EngineeringInc/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 10, 2021
@kisslorand
Bugfix for PR bigtreetech#1680 (bigtreetech#1681)
9ee29fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Popup error. [BUG] Marlin does not boot if TFT is in LCD Emulator Mode
3 participants
@guruathwal @radek8 @bigtreetech