Update Turkish Language / Board SD Printing: Show Actual Z Coordinate as Layer - Watch pause and cancel action - Bypass blocking operations on print cancel / Fix M27 time parameter /M701-M702 load/unload filament support #1272
Conversation
Update from Original #2
Update from source master
Update 18/07/2020
10/08/2020 Update
07/09/2020 güncellemesi
Master Followup 16.09.2020
Güncelleme 10/11/2020
Masterdan Güncelleme 18/11/2020
|
You are a gift from heaven!!! Thank you👍🏻 |
There was a problem hiding this comment.
I scrolled trough your code. See the individual comments.
In short:
- Use curly braces, even when it's one line
- Place curly braces on its own line. Example:
}
Else
{
- Create a space after if, while, for etc. :
if (what == true) - Line up you're code with the rest of it
Thank you
|
It seems something went wrong with my suggestions. I hope it's clear enough. Oh well. Thank you for your work! |
|
Excellent news ! Forgive my ignorance, but what should we do? Is there a file to copy directly or a patch? Do I have to replace each red line with the corresponding green line by recompiling the affected files? |
|
Hi Maker-M. Are you mehmetsutas? |
|
@traffic-light I will check your suggestions. @Maker-M You may copy paste the changes for now. But you should better wait for the changes to be merged into the source. Meanwhile people may have different comments and point out some problems with the change if there are. After merge you can download the firmware again, compile and use it. @oldman4U he is not. :) |
Great ! Thanks for your answers. |
|
Ahhhh, it is compiling;-))) We had cases where users have been logging in using different devices which resulted in different names - so this is why I asked. @mehmetsutas Thank you very much for contributing. Feel free to solve more long lasting issues #1218 or adding great features #1170 ;-)!!! |
|
You are a genius. I have noticed though that if no ABL is active (no mesh stored) the ABL icon doesn't show. I don't think this is related, as I'm sure this was mentioned elsewhere. |
mehmetsutas
changed the title
|
@oldman4U it is easier to solve when the coder personally encounter the problem. But I will have look at the list. I have added M701/702 load/unload gcode support. Will work on M600 and power loss recovery from boardsd. |
|
Hi. The problem is, that most of the developers in the past added a feature and then they disappeared. Most likely because of a completely chaotic handling of this repository. Some users including me, try to get the things organised again, by adding precompiles firmware which works and which are not several months old, by updating the ReadMe and removing things which are not working anymore. For me the most critical issue is the lack of engagement from BTT, so we try to work around this as much as we can. Thats one of the reasons we made the FR and Bug list, otherwise we would have hundreds of tickets with a search function which only works in parts and important issues and features on page 2 and later - and who reads more than the first page. So we got reports covering the same issues and the same time developers silently working on the same things. Long story short. It would be great if we could convince you to stay a bit longer, in case you are interested and in case you have a bit time to spare. Thank you |
|
Created a pull request on Marlin for reporting the cancelled SD print. |
I understand and I will try to support. It is hard for me to solve the problems of the features that I don't use but I will surely share any fix or enhancement that I make. |
|
@mehmetsutas Reallyd great to se you here, and nice finally filament chance is added... Mabye your the guy who can look at #1264 and make it? |
|
@bigtreetech Seem's like it's time to merge a Lot again... |
Let's pray and hope for the best. It is almost a bit like BTT does not want this to be a successful repository. |
… as Layer - Watch pause and cancel action - Bypass blocking operations on print cancel / Fix M27 time parameter /M701-M702 load/unload filament support (bigtreetech#1272)
Update outdated Turkish translation
During SD printing status screen showed 0mm as layer throughout the print. Actual Z position is shown which is more informative than 0mm
Pause, paused and cancel keywords are added to the hostactions to watch the boardsd prints. Now when prints are canceled by host pc, it can be detected and LCD reverts to the statusmenu from printingmenu. Cancel action on printabort will also be added to Marlin.
M524 processing was deferred by blocking operations such as extruder and bed heating processes. Break gcodes added before M524 in order to break the blocking operations and speed up the print cancel when printing from boardsd.
Miliseconds were passed as parameter to M27 gcode which expects seconds as parameter. Fixed.
Add support for M701-M702 Marlin load/unload filament gcodes. A new configuration option added for M701/702 support. A subpage added to the preaheat menu. Preheat menu moved to the main page in place of extrude menu. Extrude menu moved under move menu. After selecting the preheat option printer starts to heat on the next newly added page either filament load or unload option can be chosen or can exit without filament load/unload. Accordingly M701 or M702 gcode is sent to Marlin and Marlin handles the filament load/unload according to its setup on configuration_adv.h
resolves #1135
resolves #834
resolves #367
resolves #368