Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra column to terminal keys to move F, I, J, P & R to 123 page. Add punctuation to ABC page. #1191

Closed
wants to merge 5 commits into from

Conversation

StarNamer
Copy link

@StarNamer StarNamer commented Oct 20, 2020

Requirements

See issue #1181 . I initially was only going to add the F key, since commands like 'G0 F60 Z0' are common when adjusting Z-offset, for example., but decided by adding an extra column and making the grid 7 by 4 instead on 6 by 4 allowed I, J, P & R to also be added. Extra punctuation was added so it's possible, in theory, to start a print from SD with M23/M24 or M32.

Description

Added extra column so layouts are:

"1", "2", "3", "M", "G", "F", "Del",
"4", "5", "6", "X", "Y", "Z", "E",
"7", "8", "9", "S", "T", "P", "Space",
".", "0", "-", "I", "J", "R", "ABC",

"A", "B", "C", "D", "H", "K", "Del",
"L", "N", "O", "Q", "U", "V", "W",
":", ";", "(", ")", "/", "~", "Space",
"+", "*", "&", "$", "!", "#", "123",

Benefits

The most useful feature is the F parameter can now be specified without switching back and forth between pages.

Related Issues

As above: #1181

@traffic-light
Copy link
Contributor

traffic-light commented Oct 21, 2020

This would make the buttons even smaller then they already are.
That would be dramatic for 2.4"

Maybe it's better to make a check for screen size.
I think it's even a little too small for 3.5"

Besides that: good idea to add a new row.

@StarNamer
Copy link
Author

StarNamer commented Oct 23, 2020

Yeah, I have started looking at how to tell the various sizes apart (320x240, 480x320, etc) and will probably update with 6x4 keys for the narrower version (with the original idea of adding the "F" key) and then keep 7x4 for the 480x320 & 480x272 sizes. I don't have a TFT70, but at 800x480 that could probably handle a 10x6 keypad and just put all keys on one page!

I've been using it for over a week on my TFT35 E3 and had no problem with the key spacing.

@oldman4U
Copy link
Contributor

I believe we all did not expect someone to put so much work into a single function 😁

To show the pages depending on the number of pixels available is SUPER.

It would be my pleasure to test TFT28 and 35 and soon 24 for you if you want.

THANK YOU

@StarNamer
Copy link
Author

I've updated the code to adjust the terminal layout based on the LCD pixel width, which depends on the model of screen. I checked that all variants compile, including after merging the current start of the 'master' branch. However, I can only physically test the TFT35 E3 V3.0 variant as that's the device I have. I did locate a TFT24 on eBay for £12.09, but can't think of a use I'd have for it after the test and am not sure I'd be able to sell it on.

Note, there are obviously many ways to generate the arrays for the layouts. I've taken what I believe to be the easiest to maintain in future, which is to simply present the entire layout for each variant rather than trying to switch various elements.

@oldman4U
Copy link
Contributor

oldman4U commented Nov 1, 2020

Currently I have a 35 and a 28 and waiting for a 24 which has the same resolution like the 28. Hopefully I can test ittomorrow.

@oldman4U oldman4U mentioned this pull request Nov 2, 2020
@oldman4U
Copy link
Contributor

oldman4U commented Nov 2, 2020

Wouldn"t it be good to release it together with #1227?

@StarNamer
Copy link
Author

Since @digant73 has merged this work into #1231 , I'm closing this PR.

@StarNamer StarNamer closed this Nov 8, 2020
bigtreetech pushed a commit that referenced this pull request Nov 10, 2020
* Improved Terminal menu based on TFT size and resolution (based on PR #1191
jeffeb3 pushed a commit to V1EngineeringInc/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 10, 2021
…1231)

* Improved Terminal menu based on TFT size and resolution (based on PR bigtreetech#1191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants