New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix logger, so it can log into default production.log #5436

Closed

galupa wants to merge 1 commit into bigbluebutton:master from galupa:fix-logger

Contributor

galupa commented Oct 3, 2023

Hi,

I found out that if we not set up RAILS_LOG_TO_STDOUT and (RAILS_LOG_REMOTE_NAME or RAILS_LOG_REMOTE_PORT) env variable (e.q. we want to use default log to log into production.log file), Greenlight will raise error because the logger on line 151 (logger.formatter = config.log_formatter) is not initialised.

So this PR basically to fix it. I just move it inside the if statement.

Best Regards,


          fix logger when RAILS_LOG_TO_STDOUT and (RAILS_LOG_REMOTE_NAME or RAI…

…LS_LOG_REMOTE_PORT) is not set up

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

Collaborator

farhatahmad commented Nov 15, 2023

Fixed here: #5520

farhatahmad closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet