More defined() instead of boolean.

beyondgrep · Nov 24, 2024 · 223c0ab · 223c0ab
1 parent a439441
commit 223c0ab
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/ack b/ack
@@ -890,7 +890,7 @@ sub print_matches_in_file {
             if ( $in_range ) {
                 $match_colno = undef;
                 my $is_match = /$search_re/o;
-                if ( $is_match && $search_not_re ) {
+                if ( $is_match && defined($search_not_re) ) {
                     local @-;
                     $is_match = !/$search_not_re/o;
                 }
@@ -1139,25 +1139,25 @@ sub count_matches_in_file {
         if ( $using_ranges ) {
             while ( <$fh> ) {
                 chomp;
-                $in_range = 1 if ( !$in_range && $opt_range_start && /$opt_range_start/o );
+                $in_range = 1 if ( !$in_range && defined($opt_range_start) && /$opt_range_start/o );
                 if ( $in_range ) {
                     my $is_match = /$search_re/o;
-                    if ( $is_match && $search_not_re ) {
+                    if ( $is_match && defined($search_not_re) ) {
                         $is_match = !/$search_not_re/o;
                     }
                     if ( $is_match xor $opt_v ) {
                         ++$nmatches;
                         last if $bail;
                     }
                 }
-                $in_range = 0 if ( $in_range && $opt_range_end && /$opt_range_end/o );
+                $in_range = 0 if ( $in_range && defined($opt_range_end) && /$opt_range_end/o );
             }
         }
         else {
             while ( <$fh> ) {
                 chomp;
                 my $is_match = /$search_re/o;
-                if ( $is_match && $search_not_re ) {
+                if ( $is_match && defined($search_not_re) ) {
                     $is_match = !/$search_not_re/o;
                 }
                 if ( $is_match xor $opt_v ) {