add: Add gitlab and github workflows. Also remove GDS question and GDS files #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
===========================================
- Coverage 59.25% 47.61% -11.65%
===========================================
Files 4 4
Lines 54 42 -12
===========================================
- Hits 32 20 -12
Misses 22 22 ☔ View full report in Codecov by Sentry. |
Jacobb164
reviewed
Apr 20, 2023
There was a problem hiding this comment.
You removed these scripts. Do we need to adjust them rather than remove them completely?
| @@ -5,45 +5,6 @@ | |||
| from sphinx.cmd.build import main | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("test_input_repository_hosting_platform", ["GitHub", "GitLab"]) | |||
There was a problem hiding this comment.
Why has this been removed?
| @@ -1,3 +1,30 @@ | |||
| # Assumptions and caveats log | |||
|
|
|||
| This log contains a list of assumptions and caveats used in this analysis. | |||
|
|
|||
| ## Definitions | |||
There was a problem hiding this comment.
Did this come from Shazmeen? If it's not might be worth asking them to read it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed GDS tests and files, replacing some quality assurance docs with the GDS ones. The gds question in the cookiecutter start up has been replaced with an ONS question. This is for the gitlab ci file. Gitlab and github workflows have been added with merge templates.
check:
for (github, gitlab with ONS, gitlab no ONS)
pip install -e .
pytest
git init
pre-commit install
git add .
git commit -m "init"
github workflow
github merge request
gitlab ONS workflow
gitlab merge request
ignore gitlab no ONS workflow (not possible to test)
Checklists
This pull/merge request meets the following requirements:
docsfolderComments have been added below around the incomplete checks.