-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #153 (JDK 21+ compatibility) #154
base: master
Are you sure you want to change the base?
Conversation
This reverts commit ff23253.
Ah this is why it wasn't working with 21. Why no merge yet after 3 months? |
@PerryCameron I think the original maintainer, @siordache, simply does not have time to regularly update the project anymore. He asked for co-maintainers a while ago and someone stepped up, but it seems that person also has abandoned the project. I currently have a patched version of the plugin installed locally that fixes this and an issue with kotlin build files and am thinking of forking this and publishing an updated version to plugin central (and of course continue to stream any patches upstream in case this repo gets active again). I didn't step up as a co-maintainer back then because this project is mainly Groovy and I am really a noob in that language, but maybe I should have. In the meantime, I have volunteered to become a co-maintainer, but @siordache did not reply yet. |
That sounds very promising 👍, Thanks! |
Thank you! Not yet. It's on my list. I will post here when it's done. |
@danielpeintner I have released a patched version of the plugin to plugin central. To use it, change the plugin id in your gradle build script fom Please report back if something doesn't work. And if it's of interest to anyone, I have done the same for the sister-plugin Badass-Jlink-Plugin. Sources for my patched version of the plugin: https://github.com/xzel23/badass-runtime-plugin |
Thank you a lot! It worked nicely 👍. |
This PR fixes #153: