Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jre task should depend on any jars in the runtime classpath #131

Merged
merged 1 commit into from
Dec 25, 2022

Conversation

hakanai
Copy link
Collaborator

@hakanai hakanai commented Jul 22, 2022

Fixes #130.

allDependencies returns a lazy collection which includes all the runtime dependencies. Those which come from projects will be a ProjectDependency along the lines of:

DefaultProjectDependency{dependencyProject='project ':lib'', configuration='default'}

This seems to make it run :lib:jar as part of the dependencies for the task.

@siordache siordache merged commit 103fc70 into beryx:master Dec 25, 2022
@siordache
Copy link
Member

@hakanai: Thanks for the PR! Release 1.13.0 includes your changes.

To everyone: I didn't have much time lately for this plugin. It would be great if some of you could help co-maintain it. I created an issue to keep track of this matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jre task fails because it doesn't set the appropriate dependencies on jar tasks
2 participants