Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added decoration builder #108

Merged

Conversation

Sourav-Sonkar
Copy link
Contributor

#107
Decoration need to have access target property,as if we need to pass a custom shape , then we need get access to the target property.

Suggestion to have a call back method which provides target in the supertooltip

typedef DecorationBuilder = Decoration Function(
  Offset target,
);

@bensonarafat
Copy link
Owner

Thank @Sourav-Sonkar for your contriubtion
Let me check it out.

@Sourav-Sonkar
Copy link
Contributor Author

@bensonarafat Should i remove the Deprecated tag or remove the decoration parameter to fix the lint??

@bensonarafat
Copy link
Owner

@Sourav-Sonkar
Can't we keep both?
And set an assert. So they cant use both as the same time

@Sourav-Sonkar
Copy link
Contributor Author

Sourav-Sonkar commented Aug 4, 2024

@Sourav-Sonkar Can't we keep both? And set an assert. So they cant use both as the same time

@bensonarafat we can keep both ... but i think it would made more sense to keep DecorationBuilder only...as both will be returning decoration only

@Sourav-Sonkar Sourav-Sonkar force-pushed the feat/decoration-builder branch from 0684860 to 865793b Compare August 6, 2024 16:14
@Sourav-Sonkar
Copy link
Contributor Author

@bensonarafat removed decoration parameter

@bensonarafat
Copy link
Owner

Great @Sourav-Sonkar
Could you also add an example readme, on how this can be used?
So, this can help others
thanks

@Sourav-Sonkar
Copy link
Contributor Author

@bensonarafat add documentation please check

@bensonarafat
Copy link
Owner

Great @Sourav-Sonkar
I will merge it tomorrow.
thanks

@bensonarafat bensonarafat merged commit cc2ee93 into bensonarafat:master Aug 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants