Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
closes #60
Why
Delete and retired bikes should never be used in a new ride, so ignore them from consideration.
Details
When updating an activity, get the gear details for each gear we are considering and check that it:
Ignore any activities that use missing or retired gear when processing events. We do not make a request for more activities if most (or all) of initially requested activities are filtered out.
This also adds an N+1 request to the strava API - we make a single request for each unique gear ID appearing in recent activities. These requests are made concurrently, so impact on duration should is minimized, but it could consume our API limits more quickly.
AFAIK there is no way to request all the gear details for an athlete, or pass a list of gear IDs.
Commits