Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIMSBIOHUB-652: Manual Telemetry CSV Import #1454

Open
wants to merge 92 commits into
base: dev
Choose a base branch
from
Open

SIMSBIOHUB-652: Manual Telemetry CSV Import #1454

wants to merge 92 commits into from

Conversation

MacQSL
Copy link
Collaborator

@MacQSL MacQSL commented Dec 18, 2024 •
edited
Loading

Links to Jira Tickets

Description of Changes

Update: I have pushed up all my recent changes before leaving for Christmas break - 22/12/24

  • CSV import for manual telemetry (now stored in SIMS)
  • New CSV import dialog component
  • Standardized styling between capture multi import and CSV import dialog
  • Dialog now allows downloading of CSV template
  • New migration to add a unique constraint on (deployment_id, latitude, longitude, acquisition_date)

Testing Notes

  • Should be able to import a CSV via the import dialog and view CSV validation errors

MacQSL added 30 commits October 28, 2024 14:43
@MacQSL
chore: partially done structure for new csv import
fe045e6
@MacQSL
feat: validate method
8c0cc12
@MacQSL
chore: wip
8062962
@MacQSL
feat: progress...
a999b2d
@MacQSL
feat: added validators for cell values
79f488f
@MacQSL
chore: moved files
853cfe1
@MacQSL
feat: updated docs for types
a0c4f87
@MacQSL
feat: created new critter strategy
cb0a7b9
@MacQSL
chore: still working on strucutre for config
73a1f50
@MacQSL
feat: updated helper functions for csv-utils
1cd7235
@MacQSL
feat: updated import csv critters
c5d9b71
@MacQSL
feat: added new config header util files
0dffc39
@MacQSL
feat: added files for csv-header-config validation / setter functions
834934f
@MacQSL
chore: updated tests for cell validators
08709c1
@MacQSL
feat: updated some structure + moved validation logic into class
4e742e6
@MacQSL
feat: moved some redundant params around + seperated CSVHeaderConfig …
110766d 
…from params
@MacQSL
fix: updated some functions in csv-config-validation
2b0469b
@MacQSL
chore: tests for rorEachCSVCell
29c51b6
@MacQSL
feat: updated error formatting to be in the parent
2427513
@MacQSL
feat: partial PR comments
e1e563f
@MacQSL
feat: PR comments + additional JSDocs
61aad38
@MacQSL
feat: created type for cell setter and validator
410d0f4
@MacQSL
feat: updated tests for CSVConfigUtils
eb2b8aa
@MacQSL
feat: updated types in CSVConfigUtils
7807f4e
@MacQSL
feat: updated getters in CSVConfigUtils
75374ca
@MacQSL
chore: resolving broken tests
2e230fa
@MacQSL
feat: updated tests
d0494f4
@MacQSL
feat: added nested record class
1ae762d
@MacQSL
feat: added tests for endpoint
7cc6f4a
@MacQSL
fix: pr comments
32b4c89
@MacQSL MacQSL added the Ready For Review PR is ready for review label Dec 20, 2024
MacQSL and others added 17 commits December 20, 2024 09:10
@MacQSL
feat: added reusable CSVCellValidators
20d2d85
@MacQSL
fix: created component for options menu to prevent multiple menus ope…
f4ea8f3 
…ning onClick
@MacQSL
fix: updated openapi values type
8e631bd
@MacQSL
fix: tests
a9bca4b
@MacQSL
fix: pr comments
296ed60
@NickPhura
Update getWorksheetRowObjects.
695ff2d 
Minor tweak to csv error datagrid settings.
@MacQSL
fix: dropped symbol
8eeb9c5
@NickPhura
Merge branch 'SIMSBIOHUB-633-markings' of https://github.com/bcgov/bi…
785a9bd 
…ohubbc into SIMSBIOHUB-633-markings
@NickPhura
Merge branch 'SIMSBIOHUB-633-markings' of https://github.com/bcgov/bi…
d9f50ed 
…ohubbc into SIMSBIOHUB-633-markings
@NickPhura
Fix getWorksheetRowObjects
a763c3b
@MacQSL
feat: added symbol for worksheet rows + PR nits
aa9d2b6
@MacQSL
fix: doc language
71076df
@MacQSL
fix: created csv-utils file for types and helper functions
db6c944
@MacQSL
fix: removed optional for taxon body location
c138cf2
@MacQSL
Merge branch 'SIMSBIOHUB-633-markings' of https://github.com/bcgov/bi…
b82861f 
…ohubbc into SIMSBIOHUB-652-csv-telemetry
@MacQSL
fix: merge conflicts with dev
8b0ef99
@MacQSL
feat: partially complete telemetry import state
b0a9d4b
@MacQSL MacQSL added Not Ready For Review Addressing feedback and/or refactoring and removed Ready For Review PR is ready for review labels Dec 21, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarQube Cloud

@MacQSL MacQSL added Ready For Review PR is ready for review and removed Not Ready For Review Addressing feedback and/or refactoring labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickPhura NickPhura Awaiting requested review from NickPhura

@mauberti-bc mauberti-bc Awaiting requested review from mauberti-bc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Ready For Review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MacQSL @mauberti-bc @NickPhura