Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Okteto fixing #22

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Okteto fixing #22

wants to merge 6 commits into from

Conversation

TonioF
Copy link
Collaborator

@TonioF TonioF commented Mar 29, 2022

dev cluster is working. It turned out that there were no problems with this file after all, we just needed to restart the deployment.

@TonioF TonioF requested a review from dzelge March 29, 2022 15:53
@@ -1,16 +1,9 @@
name: xcube-hub-okteto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tonio,

name: xcube-hub

I was wrong yesterday. This line should contain the name of the deployment i.e. xcube-hub. Okteto replaces the xcube-hub pod in teh xcube-hub deployment with the okteto pod. This allows you to debug the hub within the K8s infrastructure. Nice but playing around has broken the deployment yesterday.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also has of course implications for dev. Once shoud work in the own minikube or so. Not on the dev cluster except one wants to check something specific.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice but playing around has broken the deployment yesterday.

Well, it was already broken yesterday. I applied your suggestion, so now it should be fine.

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #22 (d85d586) into master (c37c16f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   86.65%   86.65%           
=======================================
  Files          76       76           
  Lines        4625     4625           
=======================================
  Hits         4008     4008           
  Misses        617      617           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c37c16f...d85d586. Read the comment docs.

@TonioF TonioF requested a review from dzelge March 31, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants