Skip to content

Commit

Permalink
Make Bazel not crash if a runfiles tree is in a runfiles tree.
Browse files Browse the repository at this point in the history
There was a test for this, but it didn't check for the exit code, only the error message and the message printed on the crash coincidentally contained the expected message.

My best understanding is that this was broken in unknown commit. The root cause of why that change was imperfect is probably the odd behavior that if one posts an error to the event handler in ActionExecutionContext, the action doesn't automatically fail.

RELNOTES: None.
(cherry picked from commit ebced66)
  • Loading branch information
Googler authored and mai93 committed Nov 19, 2024
1 parent 00335a7 commit 3b65b05
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions third_party/bazel/src/main/protobuf/failure_details.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1256,6 +1256,7 @@ message Analysis {
INCOMPATIBLE_TARGET_REQUESTED = 19 [(metadata) = { exit_code: 1 }];
ANALYSIS_FAILURE_PROPAGATION_FAILED = 20 [(metadata) = { exit_code: 1 }];
ANALYSIS_CACHE_DISCARDED = 21 [(metadata) = { exit_code: 1 }];
INVALID_RUNFILES_TREE = 22 [(metadata) = { exit_code: 1 }];
}

Code code = 1;
Expand Down

0 comments on commit 3b65b05

Please sign in to comment.