WIP: Riak KV 1329 tests #981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… extractors test (cherry picked from commit 844ee9c)
…s-as-per-PR866 yokozuna_rt additions for types and better testing w/ allow-mult=true…
Add debugging to rt:do_commit/1 to track nothing_planned
(cherry picked from commit 867dc1a)
sure up possible race between upgrade and first check
- update `prepare` so that it waits for the vnode PID to change as it's possible that monitors haven't fired by the time we ask for a new one - Update `drain` to require 3 consecutive 0 counts from a group of PIDs rather than draining individual processes or only trying once. The number 3 was determined empirically - read the comment above `drain` if it continues to cause issues. - Rewrite `resume` to make sure things are drained properly before continuing.
…_2.0 Update proxy_overload_recovery to handle indeterminism more gracefully.
We've run into a number of issues over time where errant processes hang around and stomp on other tests, and without PIDs in the logging it can be difficult or impossible to conclusively identify and debug these kinds of problems.
Previously, wait_until_read function would execute another rt:systest_read call and return a count of errors, when we already asserted above that the list is empty. If the wait_until function does not return true, or times out, or hits the retry limit, the running test ought to fail anyway without needing an additional read to fail. So doing another call is redundant and unnecessary; we just return 0 as the value if rt:wait_until completes successfully.
Log PIDs by default for console output
Return 0 instead of doing another rt:sysread in repl_util:wait_for_reads/5
| assertEqual(RiakHttp, PBPid, ExpectedKeys, {<<"$key">>, int_to_key(0), int_to_key(999)}, ?Q_OPTS, keys), | ||
| assertEqual(RiakHttp, PBPid, ExpectedKeys, { <<"$bucket">>, ?BUCKET}, ?Q_OPTS, keys), | ||
|
|
||
| ExpectedFooKeys = lists:sort([int_to_key(N) || N <- lists:seq(101, 200)]), | ||
| assertEqual(RiakHttp, PBPid, ExpectedFooKeys, {<<"field1_bin">>, ?FOO}, ?Q_OPTS, keys), | ||
|
|
||
| assertEqual(RiakHttp, PBPid, [int_to_key(201)], {<<"field1_bin">>, ?BAZ}, ?Q_OPTS, keys), |
There was a problem hiding this comment.
Please make sure to put some comments around/before the newly added expectations so we know why they were added and what they are testing.
|
@lukebakken Would you mind doing this on the |
|
@javajolt - I'll do that when I get a chance. |
…o reproduce issue in riak_kv#1329
lukebakken
force-pushed
the
fixes/lrb/riak_kv-1329-2i-exact-match-bucket-type
branch
from
bebc8f8 to
3a6a2bc
Compare
|
@javajolt @JeetKunDoug - I rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests for 2i exact match scenarios
See basho/riak_kv#1329