Explicitly filter out non-primary exchanges #1752
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opposed to flipping indexes and allowing it to fail. Prevents logging of not_responsible messages when these errorneous exchanges are attempted.
ThomasArts
reviewed
Mar 20, 2021
| true -> | ||
| {B, A, IndexN} | ||
| end || {A, B, IndexN} <- Exchanges], | ||
| L = [Exchange || {A, B, _IndexN} = Exchange <- Exchanges, A < B], |
There was a problem hiding this comment.
I have a hard time to see that in all cases in which prune_exchages is used, this will give the desired result. The original returns all tripples {A, B, I} and ensures that A =< B for all of them. Your solution just removes all {A, B, I} if A >= B.
Apparently you want this, because that's what the commit comment states. But how is function used by the rest of riak?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly filter out non-primary exchanges from exchange_queue as opposed to flipping indexes and allowing it to fail. Prevents logging of not_responsible messages when these errorneous exchanges are attempted.
Relates to basho/riak#1011