Build TLS-enabled Riak node(s) #1014
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DO NOT MERGE in current shape. |
martincox
reviewed
Mar 25, 2020
| @@ -6,6 +6,7 @@ | |||
| ORIGINAL_DIR=$(pwd) | |||
|
|
|||
| # Make sure CWD is set to runner run dir | |||
| RUNNER_BASE_DIR={{runner_base_dir}} | |||
There was a problem hiding this comment.
Hey @hanssv, did something break that required this to be added? I think the runner_base stuff is overspill from the former node_package stuff, but isn't necessarily required any more, to my knowledge (needs a bit of cleanup to remove it).
There was a problem hiding this comment.
Yes, without this it runs in my home-directory, which means it does not find the SSL-config and thus can't talk to the node (or well it will refuse to even try to talk to it).
It wasn't necessary before (and it was horribly broken since bbmustache had HTML-encoded the bash command!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just proof of concept, but together with riak_test/use_inet_tls branch tests are being run against TLS-enabled Riak node(s). It remains to make this somewhat more user friendly/configurable.
Using TLS exposed a couple of problems with variables, and extension scripts, these were pre-existing but didn't manifest in an "all-default" setting.