Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code Dockerfile #371

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

teenager-ETH
Copy link

Pull Request Title:
Fix Dockerfile by removing redundant installation of curl, jq, and supervisor

Description:
This pull request fixes the Dockerfile by removing the redundant installation of curl, jq, and supervisor to streamline the process.

Changes Made:

  • Removed the duplicate installation command for curl, jq, and supervisor.

Files Modified:

  • geth/Dockerfile

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@teenager-ETH
Copy link
Author

I noticed an issue in the script where the command sequence apt-get install -y jq curl supervisor was used.

It seems that the order of the commands could be improved for better logic and consistency. Specifically, curl should come before jq since curl is more fundamental and commonly required first in most scenarios.

I’ve corrected this to apt-get install -y curl jq supervisor, which is more appropriate for ensuring the proper installation flow.

Stay based

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants