Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip deleted apps when updating dag_registry #588

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

marioncottard
Copy link
Collaborator

Airflow keeps in the database the dags that have been deleted, so this query:
model_dags = [ dag for dag in session.query(DagModel) for tag in dag.tags if tag.name == "model" ] returns deleted dags, which causes the update_dag_registry to fail

@marioncottard marioncottard changed the base branch from master to develop December 16, 2024 11:29
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@161e0d4). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #588   +/-   ##
==========================================
  Coverage           ?   75.36%           
==========================================
  Files              ?      258           
  Lines              ?    14490           
  Branches           ?     2004           
==========================================
  Hits               ?    10921           
  Misses             ?     3115           
  Partials           ?      454           
Flag Coverage Δ
dags-tests 77.79% <20.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
server 77.89% <0.00%> (?)
client 78.13% <0.00%> (?)
dags 77.79% <0.00%> (?)

ampuerin
ampuerin previously approved these changes Dec 17, 2024
ggsdc
ggsdc previously approved these changes Dec 18, 2024
@marioncottard marioncottard dismissed stale reviews from ggsdc and ampuerin December 18, 2024 10:07

The merge-base changed after approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants