Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/socket #580

Draft
wants to merge 24 commits into
base: develop
Choose a base branch
from
Draft

Feature/socket #580

wants to merge 24 commits into from

Conversation

marioncottard
Copy link
Collaborator

@marioncottard marioncottard commented Dec 4, 2024

Draft implementation of socketIO connections. Related to #505

@marioncottard
Copy link
Collaborator Author

@ampuerin, in order for this to work, I had to replace gevent workers by GeventWebSocketWorkers, from the gevent-websocket library. I also added a monkey patch. None of those seem to be causing any problem in local with docker, but do you think those changes could have an influence on production deployments?

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 50.73529% with 67 lines in your changes missing coverage. Please review.

Project coverage is 75.09%. Comparing base (a34a01d) to head (ba3b785).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #580      +/-   ##
===========================================
- Coverage    75.29%   75.09%   -0.20%     
===========================================
  Files          258      262       +4     
  Lines        14430    14560     +130     
  Branches      2078     2007      -71     
===========================================
+ Hits         10865    10934      +69     
- Misses        3104     3169      +65     
+ Partials       461      457       -4     
Flag Coverage Δ
client-tests 77.72% <ø> (ø)
dags-tests 77.58% <39.39%> (-0.17%) ⬇️
server-tests 77.47% <54.36%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
server 77.47% <54.36%> (-0.42%) ⬇️
client 77.72% <ø> (ø)
dags 77.58% <39.39%> (-0.17%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant