-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/socket #580
base: develop
Are you sure you want to change the base?
Feature/socket #580
Conversation
@ampuerin, in order for this to work, I had to replace gevent workers by GeventWebSocketWorkers, from the gevent-websocket library. I also added a monkey patch. None of those seem to be causing any problem in local with docker, but do you think those changes could have an influence on production deployments? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #580 +/- ##
===========================================
- Coverage 75.29% 75.09% -0.20%
===========================================
Files 258 262 +4
Lines 14430 14560 +130
Branches 2078 2007 -71
===========================================
+ Hits 10865 10934 +69
- Misses 3104 3169 +65
+ Partials 461 457 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Draft implementation of socketIO connections. Related to #505