Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/rostering opening hours #463

Merged
merged 12 commits into from
Oct 4, 2023
Merged

Feature/rostering opening hours #463

merged 12 commits into from
Oct 4, 2023

Conversation

marioncottard
Copy link
Collaborator

@marioncottard marioncottard commented May 29, 2023 •
edited by ggsdc
Loading

Closes #403

@marioncottard marioncottard requested a review from ggsdc May 29, 2023 15:09
@marioncottard marioncottard changed the base branch from master to development May 29, 2023 15:09
@codecov
Copy link

codecov bot commented May 29, 2023 •
edited
Loading

Codecov Report

Merging #463 (f0688ee) into development (00e5582) will increase coverage by 0.00%.
The diff coverage is 86.36%.

@@             Coverage Diff              @@
##           development     #463   +/-   ##
============================================
  Coverage        78.56%   78.56%           
============================================
  Files              234      234           
  Lines            12586    12653   +67     
============================================
+ Hits              9888     9941   +53     
- Misses            2698     2712   +14
Flag Coverage Δ
client-tests 78.26% <ø> (+0.02%) ⬆️
dags-tests 82.32% <86.36%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cornflow-dags/DAG/rostering/core/solution.py 100.00% <ø> (ø)
cornflow-dags/DAG/rostering/core/tools.py 100.00% <100.00%> (+9.52%) ⬆️
cornflow-dags/DAG/rostering/solvers/mip_model.py 97.11% <100.00%> (ø)
cornflow-dags/DAG/rostering/core/instance.py 97.57% <94.11%> (-1.70%) ⬇️
...s/DAG/two_dimension_bin_packing/core/experiment.py 68.75% <38.46%> (-12.83%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marioncottard
Copy link
Collaborator Author

Related to #403

@ggsdc ggsdc added enhancement New feature or request dags Issues relating to the dags rostering Issues relating to the rostering DAG labels Oct 4, 2023
@ggsdc ggsdc linked an issue Oct 4, 2023 that may be closed by this pull request
Rostering DAG: Change opening and closing hours from int to string HH:MM #403
Closed
ggsdc added 5 commits October 4, 2023 10:21
@ggsdc
Updated requirements and workflows
a7db5fb
@ggsdc
Merge branch 'development' into feature/rostering_opening_hours
51622ec 
# Conflicts:
#	.github/workflows/test_cornflow_client.yml
@ggsdc
Updated requirements
d777e41
@ggsdc
Merge branch 'development' of https://github.com/baobabsoluciones/cor…
ce26d63 
…nflow into feature/rostering_opening_hours

# Conflicts:
#	.github/workflows/test_cornflow_dags.yml
#	cornflow-dags/requirements.txt
@ggsdc
Changed workflow
f0688ee
@ggsdc ggsdc merged commit 7f40a93 into development Oct 4, 2023
27 of 28 checks passed
@ggsdc ggsdc deleted the feature/rostering_opening_hours branch October 4, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggsdc ggsdc ggsdc approved these changes

Assignees

@marioncottard marioncottard

Labels
dags Issues relating to the dags enhancement New feature or request rostering Issues relating to the rostering DAG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rostering DAG: Change opening and closing hours from int to string HH:MM
2 participants
@marioncottard @ggsdc