Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-sdk): fix get groups function #562

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

vplasencia
Copy link
Member

@vplasencia vplasencia commented Sep 25, 2024

Description

This PR:

  • Fixes the getGroups() function in the API SDK.
    • A try catch was added to add null to the credentials that are not a valid JSON string.
  • Updates the group credentials type in the API docs from object to string.
  • Updates the default value for a credential group from {} to '{"id":"BLOCKCHAIN_BALANCE","criteria":{"minBalance":"10","network":"Sepolia"}}'.
  • Improves developer experience when creating a credential groups programmatically.
  • Adds support for multiple credentials groups.
  • Adds a new script to run tests for a specific library: yarn test:library <package-name>.

Related Issue

Closes #561

Does this introduce a breaking change?

  • Yes
  • No

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bandada-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 9:27pm
bandada-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 9:27pm

@vplasencia vplasencia merged commit 805969e into dev Sep 25, 2024
5 checks passed
@vplasencia vplasencia deleted the fix/get-groups-api-sdk branch September 26, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant