Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor typos #338

Merged
merged 5 commits into from
Dec 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ It will also automatically check that the modified files comply with ESLint and

### Database

Bandada requires a SQL database to work, which is used by the `api` application.
Bandada requires an SQL database to work, which is used by the `api` application.
Bandada can work with Postgres and SQLite. Other SQL flavors should work but have not been tested yet.
You can pass the connection URL to the database using the environment variable (see below).

Expand All @@ -260,7 +260,7 @@ yarn test

### Running in Docker

You can also run Bandada using Docker by running below command in the project root:
You can also run Bandada using Docker by running the below command in the project root:

```sh
docker-compose up -d
Expand Down
11 changes: 11 additions & 0 deletions apps/api/src/app/groups/groups.controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,17 @@
return groups.map((g) => mapGroupToResponseDTO(g))
}

@Get("/cachedgroups")
@ApiOperation({ description: "Returns the cached groups." })
@ApiCreatedResponse()
async getCachedGroups() {
const groups = await this.groupsService.getCachedGroups()

console.log("Controller", groups)

Check warning on line 58 in apps/api/src/app/groups/groups.controller.ts

View workflow job for this annotation

GitHub Actions / style

Unexpected console statement

return groups
}

@Get(":group")
@ApiOperation({ description: "Returns a specific group." })
@ApiCreatedResponse({ type: Group })
Expand Down
6 changes: 6 additions & 0 deletions apps/api/src/app/groups/groups.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,12 @@
return group
}

async getCachedGroups() {
console.log("Service", Array.from(this.cachedGroups.keys()))

Check warning on line 634 in apps/api/src/app/groups/groups.service.ts

View workflow job for this annotation

GitHub Actions / style

Unexpected console statement

return Array.from(this.cachedGroups.keys())
}

/**
* Checks if a member belongs to a group.
* @param groupId Group id.
Expand Down
Loading