Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong initialization of cached groups in Group service #330

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Wrong initialization of cached groups in Group service #330

merged 1 commit into from
Nov 9, 2023

Conversation

0xjei
Copy link
Collaborator

@0xjei 0xjei commented Nov 9, 2023

Description

See #303

Related Issue

See #303

Does this introduce a breaking change?

  • Yes
  • No

We are making a small alteration to the GroupService initialization process. Previously, we erroneously performed the cachedGroups initialization in the constructor. We have now introduced a dedicated method, initialize(), which must be called immediately after creating the GroupService object.

Other information

@0xjei 0xjei requested a review from vplasencia November 9, 2023 15:28
@0xjei 0xjei self-assigned this Nov 9, 2023
@0xjei 0xjei linked an issue Nov 9, 2023 that may be closed by this pull request
API does not work properly when merging into main. #303
Closed
@0xjei 0xjei added the bug 🐛 Something isn't working label Nov 9, 2023
@vplasencia vplasencia merged commit e9bd9da into dev Nov 9, 2023
2 checks passed
vplasencia added a commit that referenced this pull request Nov 10, 2023
@vplasencia
Revert "Merge pull request #330 from privacy-scaling-explorations/fix…
a02d3bc 
…/cached-groups"

This reverts commit e9bd9da, reversing
changes made to 2e36b6d.
@vplasencia vplasencia mentioned this pull request Nov 10, 2023
Merged
@vplasencia vplasencia deleted the fix/cached-groups branch November 10, 2023 08:55
vplasencia added a commit that referenced this pull request Nov 10, 2023
@vplasencia
Merge pull request #331 from privacy-scaling-explorations/chore/rever…
f5889ce 
…t-commit

Revert Merge pull request #330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vplasencia vplasencia vplasencia approved these changes

Assignees

@0xjei 0xjei

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API does not work properly when merging into main.
2 participants
@0xjei @vplasencia