275/bulk adding removing #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
vplasencia
approved these changes
Sep 21, 2023
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
|
Hey @qope great work! Thank you so much 🚀 |
|
I'm glad to hear that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented bulk adding/removing of member IDCs #275.
Below is a list of the changes:
API Server
For off-chain operations, instead of sending a transaction for every addition/removal of a member, it's more efficient to send them all at once at the end. Therefore, I updated the API server to include the
addMembersandremoveMembersmethods to support bulk adding/removing.UI
(Add)
Supporting CSV files can be challenging because of the need to explain the acceptable format to users. As a result, I did not include CSV support. Instead, I've allowed for the addition of multiple member IDs at once, separated by commas, spaces, or new lines. This format matches the content one might copy and paste from CSV or Excel files, so it should be convenient for users of those file types.
(Remove)
I've added checkboxes to facilitate the removal of multiple member IDs simultaneously. However, as of now, only off-chain operations support removal. Thus, the checkboxes are displayed only for off-chain cases.
Related Issue
#275
Does this introduce a breaking change?
Other information