-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Build Dependency for Docker #5156
base: master
Are you sure you want to change the base?
Conversation
Allow latest version to build in Docker. Latest Revision require ffmpeg 7 to get libvodec61. Which means base image must be updated to ubuntu 24.10
Isn't ffmpeg being built from source in docker? |
Apparently not, when not explicitly installing FFMPEG it would complain libavcodec61 not found at runtime(build linux and therfore docker build would finish and report success). And when running with old dockerfile with ubuntu 22.04 the installed FFMPEG would not allign with version 61, as libavcodec61 require FFPMEG7 which is not supported on ubuntu 22 |
Given the nature and purpose of docker containers, I personally think it makes more sense to workaround the issue through building stage then adding unnecessary and potentially confusing arguments for runtime. |
Agree @PatrickChenHZ Make the suggested changes, and then it can be merged. Thank you! |
…s update a couple deprecated docker syntax. Also added more troubleshooting recommendations to DockerRun.sh
Updated accordingly, please review. |
Allow latest version/release to build in Docker.
Latest Revision require ffmpeg 7 to get libavcodec 61. Which means base image must be updated to ubuntu 24.10.