update helm charts based on new docker images #2534
Conversation
|
WalkthroughThe recent changes to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
pratapalakshmi
requested review from
Omri-Levy and
liorzam
and removed request for
liorzam
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- deploy/helm/example.values.yaml (5 hunks)
Additional context used
Gitleaks
deploy/helm/example.values.yaml
269-270: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
| applicationConfig: | ||
| VITE_API_URL: http://localhost:3000/api/v1/internal | ||
| MODE: development | ||
| VITE_IMAGE_LOGO_URL: "" |
There was a problem hiding this comment.
Ensure sensitive data is securely managed.
The VITE_API_URL and other sensitive parameters should be securely managed and not hardcoded in the configuration file. Consider using environment variables or a secrets management tool.
- VITE_API_URL: http://localhost:3000/api/v1/internal
+ VITE_API_URL: ${VITE_API_URL}Committable suggestion was skipped due to low confidence.
| @@ -206,6 +187,7 @@ websocketService: | |||
| paths: | |||
| - path: / | |||
| applicationConfig: | |||
| VITE_API_URL: http://localhost:3000/api/v1/internal | |||
There was a problem hiding this comment.
Ensure sensitive data is securely managed.
The VITE_API_URL and other sensitive parameters should be securely managed and not hardcoded in the configuration file. Consider using environment variables or a secrets management tool.
- VITE_API_URL: http://localhost:3000/api/v1/internal
+ VITE_API_URL: ${VITE_API_URL}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| VITE_API_URL: http://localhost:3000/api/v1/internal | |
| VITE_API_URL: ${VITE_API_URL} |
| applicationConfig: | ||
| VITE_API_URL: http://localhost:3000/api/v1/internal | ||
| VITE_API_KEY: secret | ||
| VITE_AUTH_ENABLED: true | ||
| VITE_MOCK_SERVER: false | ||
| VITE_POLLING_INTERVAL: 10 | ||
| VITE_ASSIGNMENT_POLLING_INTERVAL: 5 | ||
| VITE_FETCH_SIGNED_URL: false |
There was a problem hiding this comment.
Ensure sensitive data is securely managed.
The VITE_API_KEY and other sensitive parameters should be securely managed and not hardcoded in the configuration file. Consider using environment variables or a secrets management tool.
- VITE_API_KEY: secret
+ VITE_API_KEY: ${VITE_API_KEY}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| applicationConfig: | |
| VITE_API_URL: http://localhost:3000/api/v1/internal | |
| VITE_API_KEY: secret | |
| VITE_AUTH_ENABLED: true | |
| VITE_MOCK_SERVER: false | |
| VITE_POLLING_INTERVAL: 10 | |
| VITE_ASSIGNMENT_POLLING_INTERVAL: 5 | |
| VITE_FETCH_SIGNED_URL: false | |
| applicationConfig: | |
| VITE_API_URL: http://localhost:3000/api/v1/internal | |
| VITE_API_KEY: ${VITE_API_KEY} | |
| VITE_AUTH_ENABLED: true | |
| VITE_MOCK_SERVER: false | |
| VITE_POLLING_INTERVAL: 10 | |
| VITE_ASSIGNMENT_POLLING_INTERVAL: 5 | |
| VITE_FETCH_SIGNED_URL: false |
| applicationConfig: | ||
| VITE_API_URL: http://localhost:3000/api/v1/internal | ||
| VITE_KYB_DEFINITION_ID: "kyb_parent_kyc_session_example" | ||
| VITE_API_KEY: secret | ||
| VITE_ENVIRONMENT_NAME: local | ||
| VITE_DEFAULT_EXAMPLE_TOKEN: 12345678-1234-1234-1234-123456789012 | ||
| VITE_SENTRY_AUTH_TOKEN: 5 | ||
| VITE_SENTRY_DSN: false |
There was a problem hiding this comment.
Ensure sensitive data is securely managed.
The VITE_API_KEY, VITE_SENTRY_AUTH_TOKEN, and other sensitive parameters should be securely managed and not hardcoded in the configuration file. Consider using environment variables or a secrets management tool.
- VITE_API_KEY: secret
+ VITE_API_KEY: ${VITE_API_KEY}
- VITE_SENTRY_AUTH_TOKEN: 5
+ VITE_SENTRY_AUTH_TOKEN: ${VITE_SENTRY_AUTH_TOKEN}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| applicationConfig: | |
| VITE_API_URL: http://localhost:3000/api/v1/internal | |
| VITE_KYB_DEFINITION_ID: "kyb_parent_kyc_session_example" | |
| VITE_API_KEY: secret | |
| VITE_ENVIRONMENT_NAME: local | |
| VITE_DEFAULT_EXAMPLE_TOKEN: 12345678-1234-1234-1234-123456789012 | |
| VITE_SENTRY_AUTH_TOKEN: 5 | |
| VITE_SENTRY_DSN: false | |
| applicationConfig: | |
| VITE_API_URL: http://localhost:3000/api/v1/internal | |
| VITE_KYB_DEFINITION_ID: "kyb_parent_kyc_session_example" | |
| VITE_API_KEY: ${VITE_API_KEY} | |
| VITE_ENVIRONMENT_NAME: local | |
| VITE_DEFAULT_EXAMPLE_TOKEN: 12345678-1234-1234-1234-123456789012 | |
| VITE_SENTRY_AUTH_TOKEN: ${VITE_SENTRY_AUTH_TOKEN} | |
| VITE_SENTRY_DSN: false |
| BCRYPT_SALT: 10 | ||
| COMPOSE_PROJECT_NAME: ballerine-x | ||
| PORT: 3000 | ||
| DB_USER: admin | ||
| DB_PASSWORD: admin | ||
| DB_PORT: 5432 | ||
| DB_URL: postgres://admin:admin@localhost:5432/postgres | ||
| SESSION_SECRET: iGdnj4A0YOhj8dHJK7IWSvQKEZsG7P70FFehuddhFPjtg/bSkzFejYILk4Xue6Ilx9y3IAwzR8pV1gb4 | ||
| SESSION_EXPIRATION_IN_MINUTES: 60 | ||
| WORKFLOW_DASHBOARD_CORS_ORIGIN: http://localhost:5200 | ||
| BACKOFFICE_CORS_ORIGIN: http://localhost:5137 | ||
| KYB_EXAMPLE_CORS_ORIGIN: http://localhost:5201 | ||
| KYC_EXAMPLE_CORS_ORIGIN: http://localhost:5202 | ||
| API_KEY: secret | ||
| NODE_ENV: development | ||
| ENVIRONMENT_NAME: local | ||
| SENTRY_DSN: "" | ||
| WEBHOOK_URL: "" | ||
| WORKFLOW_DASHBOARD_CORS_ORIGIN: "http://localhost:5200" | ||
| KYB_EXAMPLE_CORS_ORIGIN: "http://localhost:5201" | ||
| APP_API_URL: https://alon.ballerine.dev | ||
| UNIFIED_API_URL: "https://unified-api-test.eu.ballerine.app" | ||
| EMAIL_API_TOKEN: "" | ||
| EMAIL_API_URL: "" | ||
| AWS_S3_BUCKET_NAME: "" | ||
| AWS_S3_BUCKET_KEY: "" | ||
| AWS_S3_BUCKET_SECRET: "" | ||
| AWS_REGION: "" | ||
| ADMIN_API_KEY: admin_secret | ||
| MAIL_ADAPTER: log | ||
| UNIFIED_API_URL: http://localhost:3001 | ||
| UNIFIED_API_TOKEN: secret-key | ||
| UNIFIED_API_SHARED_SECRET: shared-secret-key | ||
| SALESFORCE_API_VERSION: 58.0 | ||
| SALESFORCE_CONSUMER_KEY: "" | ||
| SALESFORCE_CONSUMER_SECRET: "" | ||
| APP_API_URL: http://localhost:3000 | ||
| COLLECTION_FLOW_URL: http://localhost:5201 | ||
| WEB_UI_SDK_URL: http://localhost:5202 | ||
| HASHING_KEY_SECRET_BASE64: JDJiJDEwJDNFeWtwWEs4QkdiczlRaWFwLkM4Vk8= | ||
| NOTION_API_KEY: secret |
There was a problem hiding this comment.
Ensure sensitive data is securely managed.
The DB_PASSWORD, SESSION_SECRET, API_KEY, EMAIL_API_TOKEN, AWS_S3_BUCKET_KEY, AWS_S3_BUCKET_SECRET, ADMIN_API_KEY, UNIFIED_API_TOKEN, UNIFIED_API_SHARED_SECRET, SALESFORCE_CONSUMER_KEY, SALESFORCE_CONSUMER_SECRET, and NOTION_API_KEY should be securely managed and not hardcoded in the configuration file. Consider using environment variables or a secrets management tool.
- DB_PASSWORD: admin
+ DB_PASSWORD: ${DB_PASSWORD}
- SESSION_SECRET: iGdnj4A0YOhj8dHJK7IWSvQKEZsG7P70FFehuddhFPjtg/bSkzFejYILk4Xue6Ilx9y3IAwzR8pV1gb4
+ SESSION_SECRET: ${SESSION_SECRET}
- API_KEY: secret
+ API_KEY: ${API_KEY}
- EMAIL_API_TOKEN: ""
+ EMAIL_API_TOKEN: ${EMAIL_API_TOKEN}
- AWS_S3_BUCKET_KEY: ""
+ AWS_S3_BUCKET_KEY: ${AWS_S3_BUCKET_KEY}
- AWS_S3_BUCKET_SECRET: ""
+ AWS_S3_BUCKET_SECRET: ${AWS_S3_BUCKET_SECRET}
- ADMIN_API_KEY: admin_secret
+ ADMIN_API_KEY: ${ADMIN_API_KEY}
- UNIFIED_API_TOKEN: secret-key
+ UNIFIED_API_TOKEN: ${UNIFIED_API_TOKEN}
- UNIFIED_API_SHARED_SECRET: shared-secret-key
+ UNIFIED_API_SHARED_SECRET: ${UNIFIED_API_SHARED_SECRET}
- SALESFORCE_CONSUMER_KEY: ""
+ SALESFORCE_CONSUMER_KEY: ${SALESFORCE_CONSUMER_KEY}
- SALESFORCE_CONSUMER_SECRET: ""
+ SALESFORCE_CONSUMER_SECRET: ${SALESFORCE_CONSUMER_SECRET}
- NOTION_API_KEY: secret
+ NOTION_API_KEY: ${NOTION_API_KEY}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| BCRYPT_SALT: 10 | |
| COMPOSE_PROJECT_NAME: ballerine-x | |
| PORT: 3000 | |
| DB_USER: admin | |
| DB_PASSWORD: admin | |
| DB_PORT: 5432 | |
| DB_URL: postgres://admin:admin@localhost:5432/postgres | |
| SESSION_SECRET: iGdnj4A0YOhj8dHJK7IWSvQKEZsG7P70FFehuddhFPjtg/bSkzFejYILk4Xue6Ilx9y3IAwzR8pV1gb4 | |
| SESSION_EXPIRATION_IN_MINUTES: 60 | |
| WORKFLOW_DASHBOARD_CORS_ORIGIN: http://localhost:5200 | |
| BACKOFFICE_CORS_ORIGIN: http://localhost:5137 | |
| KYB_EXAMPLE_CORS_ORIGIN: http://localhost:5201 | |
| KYC_EXAMPLE_CORS_ORIGIN: http://localhost:5202 | |
| API_KEY: secret | |
| NODE_ENV: development | |
| ENVIRONMENT_NAME: local | |
| SENTRY_DSN: "" | |
| WEBHOOK_URL: "" | |
| WORKFLOW_DASHBOARD_CORS_ORIGIN: "http://localhost:5200" | |
| KYB_EXAMPLE_CORS_ORIGIN: "http://localhost:5201" | |
| APP_API_URL: https://alon.ballerine.dev | |
| UNIFIED_API_URL: "https://unified-api-test.eu.ballerine.app" | |
| EMAIL_API_TOKEN: "" | |
| EMAIL_API_URL: "" | |
| AWS_S3_BUCKET_NAME: "" | |
| AWS_S3_BUCKET_KEY: "" | |
| AWS_S3_BUCKET_SECRET: "" | |
| AWS_REGION: "" | |
| ADMIN_API_KEY: admin_secret | |
| MAIL_ADAPTER: log | |
| UNIFIED_API_URL: http://localhost:3001 | |
| UNIFIED_API_TOKEN: secret-key | |
| UNIFIED_API_SHARED_SECRET: shared-secret-key | |
| SALESFORCE_API_VERSION: 58.0 | |
| SALESFORCE_CONSUMER_KEY: "" | |
| SALESFORCE_CONSUMER_SECRET: "" | |
| APP_API_URL: http://localhost:3000 | |
| COLLECTION_FLOW_URL: http://localhost:5201 | |
| WEB_UI_SDK_URL: http://localhost:5202 | |
| HASHING_KEY_SECRET_BASE64: JDJiJDEwJDNFeWtwWEs4QkdiczlRaWFwLkM4Vk8= | |
| NOTION_API_KEY: secret | |
| BCRYPT_SALT: 10 | |
| COMPOSE_PROJECT_NAME: ballerine-x | |
| PORT: 3000 | |
| DB_USER: admin | |
| DB_PASSWORD: ${DB_PASSWORD} | |
| DB_PORT: 5432 | |
| DB_URL: postgres://admin:${DB_PASSWORD}@localhost:5432/postgres | |
| SESSION_SECRET: ${SESSION_SECRET} | |
| SESSION_EXPIRATION_IN_MINUTES: 60 | |
| WORKFLOW_DASHBOARD_CORS_ORIGIN: http://localhost:5200 | |
| BACKOFFICE_CORS_ORIGIN: http://localhost:5137 | |
| KYB_EXAMPLE_CORS_ORIGIN: http://localhost:5201 | |
| KYC_EXAMPLE_CORS_ORIGIN: http://localhost:5202 | |
| API_KEY: ${API_KEY} | |
| NODE_ENV: development | |
| ENVIRONMENT_NAME: local | |
| SENTRY_DSN: "" | |
| EMAIL_API_TOKEN: ${EMAIL_API_TOKEN} | |
| EMAIL_API_URL: "" | |
| AWS_S3_BUCKET_NAME: "" | |
| AWS_S3_BUCKET_KEY: ${AWS_S3_BUCKET_KEY} | |
| AWS_S3_BUCKET_SECRET: ${AWS_S3_BUCKET_SECRET} | |
| AWS_REGION: "" | |
| ADMIN_API_KEY: ${ADMIN_API_KEY} | |
| MAIL_ADAPTER: log | |
| UNIFIED_API_URL: http://localhost:3001 | |
| UNIFIED_API_TOKEN: ${UNIFIED_API_TOKEN} | |
| UNIFIED_API_SHARED_SECRET: ${UNIFIED_API_SHARED_SECRET} | |
| SALESFORCE_API_VERSION: 58.0 | |
| SALESFORCE_CONSUMER_KEY: ${SALESFORCE_CONSUMER_KEY} | |
| SALESFORCE_CONSUMER_SECRET: ${SALESFORCE_CONSUMER_SECRET} | |
| APP_API_URL: http://localhost:3000 | |
| COLLECTION_FLOW_URL: http://localhost:5201 | |
| WEB_UI_SDK_URL: http://localhost:5202 | |
| HASHING_KEY_SECRET_BASE64: JDJiJDEwJDNFeWtwWEs4QkdiczlRaWFwLkM4Vk8= | |
| NOTION_API_KEY: ${NOTION_API_KEY} |
Tools
Gitleaks
269-270: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
|
Will re-open once the env variables dist is up and running |
Summary by CodeRabbit
New Features
headlessexample,kybapp,workflowsdashboard, andwebsocketService, improving integration capabilities.Improvements