-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hostapp: Move supervisor update logic from balenahup #3573
base: master
Are you sure you want to change the base?
Conversation
WARN "Failed fetching supervisor id from API: ${resp}" | ||
return 1 | ||
fi | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably like to understand what is the rational for the hostOS having to call the API for this and whether whatever is triggering the hostOS update should do this instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now the hostOS update is done through a call to the balenahup proxy action. The code is https://github.com/balena-os/balenahup/blob/master/upgrade-2.x.sh
We are moving away from this OS update path over to having the supervisor handle OS updates. As such, we need to move some of the steps from upgrade-2.x.sh over to the hostapp-update script.
For a time, until the supervisor managed OS updates are implemented, we will still be using OS updates through the balenahup proxy action with the changes in this commit which should still work as before.
Change-type: patch
Contributor checklist
Change-type
present on at least one commitSigned-off-by
is presentReviewer Guidelines