Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hostapp: Move supervisor update logic from balenahup #3573

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

floion
Copy link
Collaborator

@floion floion commented Dec 5, 2024

Right now the hostOS update is done through a call to the balenahup proxy action. The code is https://github.com/balena-os/balenahup/blob/master/upgrade-2.x.sh

We are moving away from this OS update path over to having the supervisor handle OS updates. As such, we need to move some of the steps from upgrade-2.x.sh over to the hostapp-update script.

For a time, until the supervisor managed OS updates are implemented, we will still be using OS updates through the balenahup proxy action with the changes in this commit which should still work as before.

Change-type: patch


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@floion floion requested a review from a team December 5, 2024 11:14
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion had a problem deploying to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Failure
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 5, 2024 11:15 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 6, 2024 07:31 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 6, 2024 07:31 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 6, 2024 07:31 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 6, 2024 07:31 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 6, 2024 07:31 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 6, 2024 07:31 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 6, 2024 07:31 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 6, 2024 07:31 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 6, 2024 07:31 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 6, 2024 07:31 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 6, 2024 07:31 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 6, 2024 07:31 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 6, 2024 07:31 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 6, 2024 07:31 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 6, 2024 07:31 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 6, 2024 07:31 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 6, 2024 07:31 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 6, 2024 07:32 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 6, 2024 07:32 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com December 6, 2024 07:32 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com December 6, 2024 08:17 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com December 6, 2024 08:17 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com December 6, 2024 08:27 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com December 6, 2024 08:27 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com December 6, 2024 08:28 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com December 6, 2024 08:28 — with GitHub Actions Inactive
WARN "Failed fetching supervisor id from API: ${resp}"
return 1
fi
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably like to understand what is the rational for the hostOS having to call the API for this and whether whatever is triggering the hostOS update should do this instead.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants