Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device-logs: Fix streaming suppressed slow read warnings out of order #1309

Merged
merged 1 commit into from
Apr 12, 2023
Merged

device-logs: Fix streaming suppressed slow read warnings out of order #1309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/features/device-logs/lib/read.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,12 @@ async function handleStreamingRead(
if (state === StreamState.Closed) {
return;
}
state = StreamState.Writable;
// Do not change to Writable, unless we are in a Saturated state.
// Eg: We shouldn't change state if we are still Buffering, waiting for
// getHistory to finish.
if (state === StreamState.Saturated) {
state = StreamState.Writable;
}
if (dropped) {
const now = Date.now();
onLog({
Expand Down