Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: Append instructions partial to externalFlash #1515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vipulgupta2048
Copy link
Member

@vipulgupta2048 vipulgupta2048 commented Dec 18, 2024

Depends on instructions partial being added to the public contracts

PRs: balena-io/contracts#454
PRs: balena-io/contracts#448
Signed-off-by: Vipul Gupta (@vipulgupta2048) [email protected]

Copy link
Contributor

@acostach acostach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vipulgupta2048 vipulgupta2048 marked this pull request as ready for review December 19, 2024 09:12
@thgreasi
Copy link
Member

@vipulgupta2048 could you also link to the contracts PR?

@thgreasi
Copy link
Member

A test case for instructions on one of this PRs would also be welcome and demonstrate the target result :)

@vipulgupta2048
Copy link
Member Author

@thgreasi both requested changes completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants