feat: new hardfork with ckb vm #1502
Conversation
| ), | ||
| }; | ||
|
|
||
| (Arc::new(Consensus::default()), Arc::new(env)) |
There was a problem hiding this comment.
Consensus includes hardfork_switch so it should be different depending on hardfork?
There was a problem hiding this comment.
no，it depends on tx_env https://github.com/nervosnetwork/ckb/blob/develop/script/src/verify.rs#L544-L548
There was a problem hiding this comment.
Doesn't this depend on both consensus.hardfork_switch() and tx_env?
There was a problem hiding this comment.
consensus.hardfork_switch() confirms the activated epoch, this is a fixed value
tx_env confirms the epoch the transaction is in. It belongs to the new environment if it is greater than the epoch in hardfork_switch.
There was a problem hiding this comment.
OK this works because Consensus::default() uses mirana hardfork switches. But it's kind of undocumented. I'm not sure whether it'll change in later versions of ckb.
|
The upgrade of ckb vm will no longer be achieved through hardfork |
What this PR does / why we need it?
This PR enable a new hardfork with ckb vm
What is the impact of this PR?
No Breaking Change
PR relation:
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci.CI Switch
CI Description