Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Profile): enhance Profile contract #305

Draft
wants to merge 9 commits into
base: release/v0.7.1
Choose a base branch
from

Conversation

nxqbao
Copy link
Contributor

@nxqbao nxqbao commented Nov 27, 2023

Description

Contract changes

The table below shows the following info:

  • Logic: the logic is changed.
  • ABI: the ABI is changed.
  • Init data: new storage field is declared and needs initializing.
  • Dependent: needs to be changed due to changes in other contracts.
Contract name Logic ABI Init data Dependent
Profile x
RoninValidatorSet x
Maintenance x
RoninTrustedOrg x
Staking x

Checklist

  • I have chosen the base of the PR to the dev branch.
  • I have named the PR following the format of [contract_name] what_is_changed, where contract_name is the list of changed contracts, separated by |, or is * if there is changed in more than 3 contracts
  • I have ticked in the Contract changes table to guide the deployer which contracts to be upgraded.
  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@nxqbao nxqbao force-pushed the fix/profile-enhance-exec branch from 2932d71 to e367570 Compare November 27, 2023 05:00
@nxqbao nxqbao marked this pull request as draft November 27, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant