-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce native support for config stores, core, SQS and SNS module #856
Introduce native support for config stores, core, SQS and SNS module #856
Conversation
@MatejNedic nice to see there's a movement towards native build support, are there any rough estimates when this PR will be merged? |
Hey hey @romangr , hopefully soon! Will work on this during a weekend |
@MatejNedic cool, thank you for your work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to run all our integration tests in a context of native image? As much as I believe that this PR works, how can we ensure that all functionality added in the future also works in the context of native image?
...d-aws-autoconfigure/src/main/java/io/awspring/cloud/autoconfigure/config/ConfigStoreAOT.java
Outdated
Show resolved
Hide resolved
@MatejNedic , any reason why this is not compatible with 3.1.2? |
When are we going to get this PR merged? |
There is support for native testing |
# Conflicts: # spring-cloud-aws-dependencies/pom.xml
@maciejwalkowiak / @MatejNedic - just one hint I stumbled across when I used Spring Cloud AWS with S3 support. You are using the Common Runtime Builder for S3 - so you have to mention / or include the aws-crt dependency and advice users to copy the library manually during a native image build. See: and https://github.com/awslabs/aws-crt-java?tab=readme-ov-file#graalvm-support |
Hey @klopfdreh , thanks on the heads up! Much appreciated! I will put this in docs with link to aws docs |
@maciejwalkowiak When you are ready merge :) |
Yes all of these can be solved :) |
📢 Type of change
📜 Description
Currently creating native image for using core, both configs, SQS and SNS work and polls on start of native executable.
Closes #673 and partially #468
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps