Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce native support for config stores, core, SQS and SNS module #856

Merged
merged 22 commits into from
Dec 10, 2024

Conversation

MatejNedic
Copy link
Member

@MatejNedic MatejNedic commented Aug 1, 2023

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Currently creating native image for using core, both configs, SQS and SNS work and polls on start of native executable.
Closes #673 and partially #468

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions github-actions bot added the component: sqs SQS integration related issue label Aug 2, 2023
@MatejNedic MatejNedic marked this pull request as ready for review August 2, 2023 18:58
@MatejNedic MatejNedic changed the title Draft: Introduce native support for config stores and core module Introduce native support for config stores, core and SQS module Aug 2, 2023
@github-actions github-actions bot added the component: sns SNS integration related issue label Aug 4, 2023
@MatejNedic MatejNedic added component: secrets-manager Secrets Manager integration related issue component: parameter-store Parameter Store integration related issue labels Aug 4, 2023
@MatejNedic MatejNedic changed the title Introduce native support for config stores, core and SQS module Introduce native support for config stores, core, SQS and SNS module Aug 4, 2023
@github-actions github-actions bot added the component: s3 S3 integration related issue label Aug 4, 2023
@romangr
Copy link

romangr commented Oct 17, 2023

@MatejNedic nice to see there's a movement towards native build support, are there any rough estimates when this PR will be merged?

@MatejNedic
Copy link
Member Author

Hey hey @romangr , hopefully soon! Will work on this during a weekend

@romangr
Copy link

romangr commented Oct 19, 2023

@MatejNedic cool, thank you for your work!

Copy link
Contributor

@maciejwalkowiak maciejwalkowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to run all our integration tests in a context of native image? As much as I believe that this PR works, how can we ensure that all functionality added in the future also works in the context of native image?

@MatejNedic MatejNedic added this to the 3.2.0 milestone Aug 1, 2024
@meletis
Copy link

meletis commented Aug 1, 2024

@MatejNedic , any reason why this is not compatible with 3.1.2?

@ksanjeev9211
Copy link

When are we going to get this PR merged?

@maciejwalkowiak maciejwalkowiak modified the milestones: 3.2.0, 3.3.x Sep 16, 2024
@helpermethod
Copy link

Is there a way to run all our integration tests in a context of native image? As much as I believe that this PR works, how can we ensure that all functionality added in the future also works in the context of native image?

There is support for native testing

https://docs.spring.io/spring-boot/how-to/native-image/testing-native-applications.html#howto.native-image.testing.with-native-build-tools.maven

# Conflicts:
#	spring-cloud-aws-dependencies/pom.xml
@github-actions github-actions bot removed component: parameter-store Parameter Store integration related issue component: secrets-manager Secrets Manager integration related issue type: dependency-upgrade Dependency version bump labels Dec 8, 2024
@klopfdreh
Copy link
Contributor

@maciejwalkowiak / @MatejNedic - just one hint I stumbled across when I used Spring Cloud AWS with S3 support.

You are using the Common Runtime Builder for S3 - so you have to mention / or include the aws-crt dependency and advice users to copy the library manually during a native image build.

See:

awslabs/aws-crt-java#834

and

https://github.com/awslabs/aws-crt-java?tab=readme-ov-file#graalvm-support

@MatejNedic
Copy link
Member Author

Hey @klopfdreh , thanks on the heads up! Much appreciated!
From what I have read if users include aws-crt dependency on their side and copy the file they should be all right?

I will put this in docs with link to aws docs

@github-actions github-actions bot added the type: documentation Documentation or Samples related issue label Dec 8, 2024
@maciejwalkowiak maciejwalkowiak modified the milestones: 3.3.x, 3.3.0 M2 Dec 9, 2024
@MatejNedic
Copy link
Member Author

@maciejwalkowiak When you are ready merge :)

@maciejwalkowiak maciejwalkowiak merged commit a08ebc1 into awspring:main Dec 10, 2024
4 checks passed
@maciejwalkowiak
Copy link
Contributor

Done :-) It fixes all of these, right? #468, #673, #1021, #1040

@MatejNedic
Copy link
Member Author

Yes all of these can be solved :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: core Core functionality related issue component: s3 S3 integration related issue component: sns SNS integration related issue component: sqs SQS integration related issue type: documentation Documentation or Samples related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Native image SpringCloudClientConfiguration.properties file is missing
7 participants