Introduce Analzyer for exceptions that happen during loading. #1309
+67
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…happen during loading.
MatejNedic
requested review from
maciejwalkowiak and
tomazfernandes
as code owners
github-actions
bot
added
the
component: parameter-store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
We are wrapping
AwsParameterPropertySourceNotFoundExceptionby re throwing it asConfigDataResourceNotFoundException, this means thatConfigDataNotFoundFailureAnalyzerwill pick it up and wrong message will be printed once error happens.@maciejwalkowiak I am not happy with the naming (and I have no inspiration how to call it). So please make a review before I change S3 and SecretsManager integration as well.
💡 Motivation and Context
closes #706
💚 How did you test it?
📝 Checklist
🔮 Next steps