Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(be+fe): custom DB Sourcecatalog #276

Merged
merged 3 commits into from
Sep 19, 2023
Merged

feat(be+fe): custom DB Sourcecatalog #276

merged 3 commits into from
Sep 19, 2023

Conversation

530051970
Copy link
Contributor

@530051970 530051970 commented Sep 19, 2023

**What is the current behavior?

Please describe the current behavior of the code that you are trying to modify. This could include any issues or limitations that you are addressing.

**What is the updated behavior?

Please describe the changes you are making to the code's behavior. This could include new features or enhancements that you are adding, as well as how they differ from the current behavior.

**Checklist

Please check off the following items before submitting your pull request:

  • I have tested my changes.
  • No sensitive information is included.
  • I've reviewed my changes to ensure they won't cause any new issues that could affect the stability or performance of the codebase.

Please check off the following items if this changes include API modefications:

  • I confirm this changes has been test with authorization validation steps, it won't break the authorization token verification mechanism.
  • I confirm this changes won't cause security issues.

@530051970 530051970 requested a review from a team as a code owner September 19, 2023 07:22
@530051970 530051970 changed the title feat(be+fe): custom DB Source&catalog feat(be+fe): custom DB Sourcecatalog Sep 19, 2023
@530051970 530051970 requested a review from yanbasic September 19, 2023 07:28
Copy link
Contributor

@yanbasic yanbasic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@530051970 530051970 merged commit e90cc11 into main Sep 19, 2023
70 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants