Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do Not Merge] Temporarily adding logic to create sagemaker client with endpoint url #389

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

leleamol
Copy link
Contributor

Description of changes:

Style and formatting:

I have run pre-commit install to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Oct 28, 2020

Codecov Report

Merging #389 into master will decrease coverage by 20.76%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #389       +/-   ##
===========================================
- Coverage   85.49%   64.72%   -20.77%     
===========================================
  Files          86       86               
  Lines        6514     6517        +3     
===========================================
- Hits         5569     4218     -1351     
- Misses        945     2299     +1354     
Impacted Files Coverage Δ
smdebug/rules/action/stop_training_action.py 78.46% <100.00%> (+1.04%) ⬆️
smdebug/tensorflow/singleton_utils.py 0.00% <0.00%> (-100.00%) ⬇️
smdebug/tensorflow/collection.py 0.00% <0.00%> (-95.88%) ⬇️
smdebug/tensorflow/keras.py 0.00% <0.00%> (-92.33%) ⬇️
smdebug/tensorflow/tensor_ref.py 0.00% <0.00%> (-88.71%) ⬇️
smdebug/tensorflow/utils.py 0.00% <0.00%> (-88.33%) ⬇️
smdebug/tensorflow/session.py 6.25% <0.00%> (-85.58%) ⬇️
smdebug/tensorflow/base_hook.py 2.38% <0.00%> (-78.18%) ⬇️
smdebug/tensorflow/version_check.py 0.00% <0.00%> (-75.00%) ⬇️
smdebug/tensorflow/__init__.py 37.50% <0.00%> (-62.50%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 311a6f4...1ea2597. Read the comment docs.

@NihalHarish
Copy link
Contributor

How is this logic being tested?

@leleamol
Copy link
Contributor Author

How is this logic being tested?

This change we may not want to merge. It made to enable the spot training testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants