Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flaky Pytorch Multiprocessing Test #368

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

NihalHarish
Copy link
Contributor

@NihalHarish NihalHarish commented Oct 3, 2020

Description of changes:

  • The dataset must be prepared outside of the child processes as opposed to inside of them which leads to race conditons.

Style and formatting:

I have run pre-commit install to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2020

Codecov Report

Merging #368 into master will decrease coverage by 2.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
- Coverage   85.47%   82.68%   -2.79%     
==========================================
  Files          86       86              
  Lines        6504     6504              
==========================================
- Hits         5559     5378     -181     
- Misses        945     1126     +181     
Impacted Files Coverage Δ
smdebug/pytorch/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
smdebug/pytorch/singleton_utils.py 0.00% <0.00%> (-100.00%) ⬇️
smdebug/pytorch/collection.py 0.00% <0.00%> (-90.00%) ⬇️
smdebug/pytorch/hook.py 0.00% <0.00%> (-82.41%) ⬇️
smdebug/rules/action/stop_training_action.py 56.45% <0.00%> (-20.97%) ⬇️
smdebug/pytorch/utils.py 0.00% <0.00%> (-18.52%) ⬇️
smdebug/rules/req_tensors.py 79.16% <0.00%> (-11.12%) ⬇️
smdebug/core/tfevent/util.py 92.00% <0.00%> (-8.00%) ⬇️
smdebug/tensorflow/callable_cache.py 78.26% <0.00%> (-4.35%) ⬇️
smdebug/rules/action/action.py 91.83% <0.00%> (-4.09%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb8f4b9...19fc0d7. Read the comment docs.

@NihalHarish NihalHarish changed the title draft Fix Flaky Pytorch Multiprocessing Test Oct 3, 2020
Copy link
Contributor

@ndodda-amazon ndodda-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #368 into master will decrease coverage by 2.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
- Coverage   85.47%   82.69%   -2.79%     
==========================================
  Files          86       86              
  Lines        6507     6507              
==========================================
- Hits         5562     5381     -181     
- Misses        945     1126     +181     
Impacted Files Coverage Δ
smdebug/pytorch/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
smdebug/pytorch/singleton_utils.py 0.00% <0.00%> (-100.00%) ⬇️
smdebug/pytorch/collection.py 0.00% <0.00%> (-90.00%) ⬇️
smdebug/pytorch/hook.py 0.00% <0.00%> (-82.41%) ⬇️
smdebug/rules/action/stop_training_action.py 56.45% <0.00%> (-20.97%) ⬇️
smdebug/pytorch/utils.py 0.00% <0.00%> (-18.52%) ⬇️
smdebug/rules/req_tensors.py 79.16% <0.00%> (-11.12%) ⬇️
smdebug/core/tfevent/util.py 92.00% <0.00%> (-8.00%) ⬇️
smdebug/tensorflow/callable_cache.py 78.26% <0.00%> (-4.35%) ⬇️
smdebug/rules/action/action.py 91.83% <0.00%> (-4.09%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f5b06d...5a19fd0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants